Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: numPages in pagination adding camelCaseObject. #9

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix: numPages in pagination adding camelCaseObject. #9

merged 1 commit into from
Sep 21, 2023
+29 −29

Conversation

anfbermudezme
Copy link
Contributor

@anfbermudezme anfbermudezme commented Sep 21, 2023 •
edited
Loading

Description

In accordance with the Minimum Viable Product (MVP) requirements and following the discovery made in https://agile-jira.pearson.com/browse/PADV-645 we need to implement a way to obtain first access, last access and grade of a CCX.

Changes Made

  • Add camelCaseObject fetching the API endpoint.
  • Change to camelcase the related strings.
  • Fix numPages in Students view.

Before:

image

After:

image

  • Update tests.

How to test

  • Up openedx services (including Course Operations)
  • Run npm install
  • Run npm start
  • Go to http://localhost:1980/
  • See the data by Institution Admin or Global Admin

@anfbermudezme anfbermudezme merged commit 309c0cf into master Sep 21, 2023
2 checks passed
@anfbermudezme anfbermudezme mentioned this pull request Sep 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergivalero20 sergivalero20 sergivalero20 approved these changes

@Squirrel18 Squirrel18 Squirrel18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anfbermudezme @Squirrel18 @sergivalero20